search

artemiscloud / activemq-artemis-operator

Apache License 2.0
66 stars 62 forks source link

Custom GRPC and HTTPGet probes doesn't works #987

Closed brusdev closed 2 months ago

brusdev commented 2 months ago

Describe the bug Custom GRPC and HTTPGet probes cause StatafulSets with wrong probe settings, i.e. a liveness probe with httpGet action cause StatafulSet with a liveness probe without a probe handler:

kind: ActiveMQArtemis
apiVersion: broker.amq.io/v1beta1
metadata:
  name: ex-aao
spec:
  deploymentPlan:
    livenessProbe:
      failureThreshold: 3
      httpGet:
        port: 8161
      periodSeconds: 10
      successThreshold: 1
      timeoutSeconds: 5
        livenessProbe:
          failureThreshold: 3
          periodSeconds: 10
          successThreshold: 1
          timeoutSeconds: 5

[!TIP] Vote this issue reacting with :+1: or :-1:

brusdev commented 2 months ago

Resolved by https://github.com/artemiscloud/activemq-artemis-operator/commit/9cec8a9d523166ee0c5ae26415d0edd8f26dec3e