search

artemsen / swaykbdd

Keyboard layout switcher for Sway
MIT License
72 stars 5 forks source link

Tabs support #7

Closed artemsen closed 9 months ago

artemsen commented 9 months ago

@dmitry-j-mikhin, please take a look.

dmitry-j-mikhin commented 9 months ago

@dmitry-j-mikhin, please take a look.

Looks good and consistent. And one more thing, just to discuss. wnd_id += cnt_id can be wrapped around, and there is a possibility of matching with another window/tab, although the probability of this is very low. You can limit the hash range to reduce this likelihood (e.g. removing the most significant bit in it), but it may not be worth it)