arter97 / exfat-linux

EOL exFAT filesystem module for Linux kernel. Everyone should be using https://github.com/namjaejeon/linux-exfat-oot instead.
Other
262 stars 59 forks source link

Added support for ≥5.8.0 Linux kernel #35

Closed gerrydoro closed 3 years ago

arter97 commented 3 years ago

I'm sorry, I should have left you a reply earlier.

I really don't want to add support for v5.8 or higher, which is why I manually added the #error macro.

This tree is effectively an out-of-date version of v5.8's exFAT, and maintaining support for v5.8+ is duplicating upstream's work(by reverting and adding #if macros), and the upstream one will always be better maintained than this one.

Even in your case, I still don't think you should be using this tree. Climbing back up my memory tree, your pull-request seems to leave out some v5.8-specific stuffs that I reverted in order to backport.

What I suggest you instead:

  1. Download v5.9 kernel source(its exFAT sources are compatible with v5.8 while v5.10 is not)
  2. cd fs/exfat
  3. Copy Makefile from this tree
  4. Remove xattr.o from Makefile
  5. Build

This will be a much better workaround until Raspberry Pi folks enable exFAT from their kernel.

gerrydoro commented 3 years ago

Hi @arter97, thanks for the reply. I understand your decision, filling the code with pragma marks is not the best way to handle compatibility with a kernel version that should already have exfat support. I will try with your suggestion instead. Thank you very much. I learned loads of things even by just trying to make the thing works! 😂