search

arteria / cmsplugin-contact-plus

With cmsplugin-contact-plus building custom forms for your django-cms project is a breeze. Now it's so easy to build the forms with exactly the fields you want in the order you want - with a minimal effort.
https://github.com/arteria/cmsplugin-contact-plus
BSD 3-Clause "New" or "Revised" License
30 stars 33 forks source link

django-inline-ordering does not work #44

Closed rfleschenberg closed 7 years ago

rfleschenberg commented 7 years ago

It seems that cmsplugin-contact-plus depends on django-inline-ordering. The user should add django-inline-ordering to INSTALLED_APPS, but this is not documented. Easy fix, add this to the README.

However, with inline-ordering in INSTALLED_APPS, I am running into another problem:

Uncaught TypeError: InlineOrdering.jQuery(...).sortable is not a function

The last commit in https://github.com/centralniak/django-inline-ordering is from 2013. Maybe it's time to replace that dependency?

jvamvas commented 7 years ago

Thank you for pointing this out, @rfleschenberg. With v1.3.5, we have replaced django-inline-ordering with https://github.com/iambrandontaylor/django-admin-sortable.

Please note the upgrading instruction on https://github.com/arteria/cmsplugin-contact-plus/releases/tag/v1.3.5