search

arteria / cmsplugin-contact-plus

With cmsplugin-contact-plus building custom forms for your django-cms project is a breeze. Now it's so easy to build the forms with exactly the fields you want in the order you want - with a minimal effort.
https://github.com/arteria/cmsplugin-contact-plus
BSD 3-Clause "New" or "Revised" License
30 stars 33 forks source link

New migrations are no longer made for every settings.ADMINS change #51

Closed raiderrobert closed 6 years ago

raiderrobert commented 7 years ago

Replaced explicit constant call with callable and updated migrations to match. This pattern is the best practice for how to accomplish this kind of problem.

jvamvas commented 7 years ago

Note: This PR is compatible with Django >= 1.7

raiderrobert commented 7 years ago

@jvamvas, that's correct.

philippeowagner commented 6 years ago

@raiderrobert @jvamvas I did not noticed this PR up to now. My fault, sorry... Could it still be merged?

@raiderrobert thanks for your contribution.

raiderrobert commented 6 years ago

Hey @philippeowagner, this change is very old at this point. It has some merge conflicts in it, and given the time that's gone by, I'm not sure of the impact of some of things to reconcile in the request. Additionally, I don't have time right now to reconcile them. Feel free to take it, but I was just trying to clean up old PRs.

walterrenner commented 6 years ago

I cherry picked the changes in 58dbc76d6cf2b4cc499e4ca5d4b11d762d7c0a19.

This will be fixed in the next release. Thanks @raiderrobert for pointing this out.