search

arteria / django-compat

Forward and backwards compatibility layer for Django 1.4, 1.7, 1.8, 1.9, 1.10, and 1.11
MIT License
106 stars 30 forks source link

Django 2.1 #66

Open jayvdb opened 5 years ago

jayvdb commented 5 years ago

Tests fail with

  File "/home/abuild/rpmbuild/BUILD/django-compat-1.0.15/compat/tests/urls.py", line 5, in <module>
    url(r'^accounts/logout/$', views.logout, name='logout'),
AttributeError: module 'django.contrib.auth.views' has no attribute 'logout'

Fairly simple to fix https://stackoverflow.com/questions/47065438/attributeerror-module-django-contrib-auth-views-has-no-attribute

jayvdb commented 5 years ago

Also running the tests on Django 2.2 results in

[  217s] ERRORS:
[  217s] ?: (admin.E404) 'django.contrib.messages.context_processors.messages' must be enabled in DjangoTemplates (TEMPLATES) in order to use the admin application.
[  217s] ?: (admin.E406) 'django.contrib.messages' must be in INSTALLED_APPS in order to use the admin application.
[  217s] ?: (admin.E407) 'django.contrib.sessions' must be in INSTALLED_APPS in order to use the admin application.
[  217s] ?: (admin.E408) 'django.contrib.auth.middleware.AuthenticationMiddleware' must be in MIDDLEWARE in order to use the admin application.
[  217s] ?: (admin.E409) 'django.contrib.messages.middleware.MessageMiddleware' must be in MIDDLEWARE in order to use the admin application.
jayvdb commented 5 years ago

fwiw, https://github.com/pakal/django-compat-patcher/issues/2 was fixed, so it is probably possible to use that patcher to fix this codebase to make it work with Django 2 ;-)