search

artesaos / seotools

SEO Tools for Laravel
MIT License
3.07k stars 503 forks source link

Not working in Laravel 5.5 #100

Closed MonrealRyan closed 6 years ago

MonrealRyan commented 6 years ago

i try to run the vendor publish but don't see the plugin

carusogabriel commented 6 years ago

I’ve already submitted a PR (#97), was merged, but not release yet 🙁

MonrealRyan commented 6 years ago

@gabriel-caruso - any reason why it does not release?

almamund commented 6 years ago

If you're using laravel's package auto discovery, config wont be published. Add service provider in app.php.

carusogabriel commented 6 years ago

@vinicius73 Could you publish the new version with Package Discovery support? :smile:

MonrealRyan commented 6 years ago

@dinajpuri I tried it but it does not work.

Note: If you are using Laravel 5.5, the steps 2 and 3, for providers and aliases, are unnecessaries. SEOTools supports Laravel new Package Discovery.

almamund commented 6 years ago

Strange! I just published it again (screenshot). My laravel version is 5.5.14 seotools

Btw, I know that adding providers and aliases are not necessary. But without adding service provider the config file was not being published.

jnbn commented 6 years ago

can you please release 0.11.0 @vinicius73 ?

isneezy commented 6 years ago

+1

vinicius73 commented 6 years ago

v0.11.1 published https://github.com/artesaos/seotools/releases/tag/v0.11.1

please send feedbacks

jnbn commented 6 years ago

Thanks ;)

carusogabriel commented 6 years ago

@vinicius73 Is working perfectly in Laravel 5.5, thanks :clap:

@MonrealRyan Update your artesao/seotools to version 0.11.1 and you're ready to go with Laravel 5.5. You can close this issue.

MonrealRyan commented 6 years ago

@gabriel-caruso - got it, sorry for late response. :) and thank you very much for the work :)