search

artesaos / seotools

SEO Tools for Laravel
MIT License
3.11k stars 503 forks source link

this package is broken #130

Closed SaphiLC closed 5 years ago

SaphiLC commented 6 years ago

If i use SEO::setDescription and then SEO::opengraph()->setDescription or SEO::opengraph()->addAttribute('description'... only the description meta renders, for twitter, its always empty... if i remove SEO::setDescription then og description appears... so, either the documentation is wrong, or this packed is buggy

SaphiLC commented 5 years ago

and looks like its also abandoned...

pmochine commented 5 years ago

@SaphiLC so I'm not using SEO:: currently, but this works fine

    SEOMeta::setTitle('Home');
    SEOMeta::setDescription('This is my page description');
    SEOMeta::setCanonical('https://codecasts.com.br/lesson');

    OpenGraph::setDescription('This is my page description');
    OpenGraph::setTitle('Home');
    OpenGraph::setUrl('http://current.url.com');
    OpenGraph::addProperty('type', 'articles');

    Twitter::setTitle('Homepage');
    Twitter::setSite('@LuizVinicius73');
Kolpikov commented 5 years ago

@SaphiLC please give more details about issue:

  1. what version of library do you use?
  2. How do you test the output?

And please note that OpenGraph provider does not contain method addAttribute it has method addProperty.

I followed your scenario with the current version v.0.14.0 and everything works fine:

  1. Set description for all providers: SEO::setDescription('Sample Description'); in debug I see that all providers contain description value.

  2. Then set other description for OpenGraph: SEO::opengraph()->setDescription('Other Description'); and can see that description was updated for openGraph provider to new value.