[question] Is there any reason why the OG and twitter title does not have defaults like html title ?

artesaos / seotools

SEO Tools for Laravel

MIT License

3.04k stars 503 forks source link

[question] Is there any reason why the OG and twitter title does not have defaults like html title ? #152

Closed WhereIsLucas closed 4 years ago

WhereIsLucas commented 4 years ago

I think it would be logical to have defaults items as well in these tags. I'm ready to code it and to open a PR, but if there's a valid reason behind this, I won't do it.

Thanks for the answer

klimov-paul commented 4 years ago

There are defaults both for OpenGraph and Twitter at config file: https://github.com/artesaos/seotools/blob/master/src/resources/config/seotools.php#L32_L39 https://github.com/artesaos/seotools/blob/master/src/resources/config/seotools.php#L45-L49

You can place any tag you want there. I can not see any problem here.