By default, OpenGraph url set to false in config file. When I set a custom url by OpenGraph::setUrl('https://some.url') it doesn't reflect, open graph url will not render due to this PR - https://github.com/artesaos/seotools/pull/148
It works only if you set default config value to null instead of false.
What is the expected result?
Ability to set custom open graph url regardless of default url value
What do you get instead?
Ability to set custom open graph url only if change a default config value to null
What steps will reproduce the problem?
By default, OpenGraph url set to
false
in config file. When I set a custom url byOpenGraph::setUrl('https://some.url')
it doesn't reflect, open graph url will not render due to this PR - https://github.com/artesaos/seotools/pull/148 It works only if you set default config value tonull
instead offalse
.What is the expected result?
Ability to set custom open graph url regardless of default url value
What do you get instead?
Ability to set custom open graph url only if change a default config value to null
Additional info
I think condition on this row should be:
or
I have tried to fix it, but I have many failures in different tests when I download repository. Haven't idea how it passes on Travis:
I have this result on fresh checkout to v0.16.0, without any changes