titleBefore config generate title in wrong order.

artesaos / seotools

SEO Tools for Laravel

MIT License

3.1k stars 505 forks source link

titleBefore config generate title in wrong order. #184

Closed Okipa closed 5 years ago

Okipa commented 5 years ago

What steps will reproduce the problem?

Set meta.defaults.titleBefore to true.

What is the expected result?

Getting an SEO friendly title in this order Dynamic title - Site name.

What do you get instead?

We currently get the title in the wrong order : Site name - Dynamic title, which is not correct.

Additional info

Q	A
This Package Version	0.16.0
Laravel Framework Version	5.8.35
PHP version	7.3
Operating system	Ubuntu

Okipa commented 5 years ago

Well, I realized that I misunderstood the feature while I was preparing a PR.
meta.default.titleBefore just define if the default title will be positionned before or after the dynamic title.
I didn't realized that the default title is always displayed now.

j3-solutions commented 1 year ago

Hello, regarding the issue of automatically displaying the default title configured in config/seotools.php, is there a scheduled date for implementing the key titleAfter => false?