search

artesaos / seotools

SEO Tools for Laravel
MIT License
3.12k stars 506 forks source link

Prevent self-closing tag syntax #287

Closed stefket closed 2 years ago

stefket commented 2 years ago
Q A
Is bugfix? ❌
New feature? ✔️
Breaks BC? ❌
Tests pass? ✔️
Fixed issues -

The w3c validator recently produces warnings, if you use the self-closing tag syntax.

J-Brk commented 2 years ago

Thank you for your contribution. Are you sure the w3c change is recent? Because as I remember this recommendation / problem has been around for a long time.

I think it would be good to match the w3c standard. Unfortunately, most developers are using open and self-closing without any consistency, just take this GitHub page as example where both are used.

stefket commented 2 years ago

I think it's a recent change, but I'm not sure.

The w3c validator links to the following page: https://google.github.io/styleguide/htmlcssguide.html#Document_Type with the following statement:

Although fine with HTML, do not close void elements, i.e. write <br>, not <br />.

stefket commented 2 years ago

I've found a post on stackoverflow https://stackoverflow.com/a/73870374/2499739 where someone writes, that this is a pretty new change.

vinicius73 commented 2 years ago

To make sure it will not cause problems, what do you think about release it as a major version @J-Brk ?

J-Brk commented 2 years ago

@vinicius73 Yeah, good idea, let's make this a new major version!