artesaos / seotools

SEO Tools for Laravel
MIT License
3.12k stars 505 forks source link

PHPUnit 10 - adjustments #305

Closed J-Brk closed 1 year ago

J-Brk commented 1 year ago

PHPUnit 10 dropped support for the verbose flag; resulting in failure of the automated Github tests.

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Tests pass?
Fixed issues
J-Brk commented 1 year ago

There were 3 PHPUnit test runner warnings:

1) Test results may not be as expected because the XML configuration file did not pass validation:

Line 12:

2) Class Artesaos\SEOTools\Tests\BaseTest declared in /home/runner/work/seotools/seotools/tests/SEOTools/BaseTest.php is abstract

3) Class SeoToolsTraitStub cannot be found in /home/runner/work/seotools/seotools/tests/SEOTools/stubs/SeoToolsTraitStub.php

--

4 tests triggered 4 PHPUnit deprecations:

1) Artesaos\SEOTools\Tests\SEOMetaTest::test_get_canonical_null Data Provider method Artesaos\SEOTools\Tests\SEOMetaTest::dataTestUrls() is not static

/home/runner/work/seotools/seotools/tests/SEOTools/SEOMetaTest.php:182

2) Artesaos\SEOTools\Tests\SEOMetaTest::test_get_canonical_full Data Provider method Artesaos\SEOTools\Tests\SEOMetaTest::dataTestUrls() is not static

/home/runner/work/seotools/seotools/tests/SEOTools/SEOMetaTest.php:194

3) Artesaos\SEOTools\Tests\SEOMetaTest::test_get_canonical_current Data Provider method Artesaos\SEOTools\Tests\SEOMetaTest::dataTestUrls() is not static

/home/runner/work/seotools/seotools/tests/SEOTools/SEOMetaTest.php:206

4) Artesaos\SEOTools\Tests\SEOToolsServiceProviderTest::test_container_are_provided Data Provider method Artesaos\SEOTools\Tests\SEOToolsServiceProviderTest::bindsListProvider() is not static

/home/runner/work/seotools/seotools/tests/SEOTools/SEOToolsServiceProviderTest.php:18

J-Brk commented 1 year ago