search

artesaos / seotools

SEO Tools for Laravel
MIT License
3.12k stars 506 forks source link

Temp Fix - PHPUnit 9 #308

Closed J-Brk closed 1 year ago

J-Brk commented 1 year ago

Pin PHPUnit to version 9; to make sure the automated tests remain operational.

Q A
Is bugfix? ✔️
New feature? ❌
Breaks BC? ❌
Tests pass? ✔️
Fixed issues
J-Brk commented 1 year ago

@vinicius73 Can you review this request primarily? I have added it because PHPUnit updated to version 10; that makes all our automated checks fail since they are based on version 9. This merge pins PHPUnit to version 9 for now; while I'm preparing the merge for version 10 in #306 . After this v9 has been fixed; #304 and #297 should be able to be merged so please review if they can be done after this merge.

J-Brk commented 1 year ago

@vinicius73 Normally I wait for you to do the final review of the PR before merging but since this is a very minor adjustment & to prevent delay for item #304; I have decided to push ahead and merge this item.