search

artfwo / pymonome

python library for interacting with monome devices
MIT License
55 stars 10 forks source link

Move Monome.disconnect to aiosc.OSCProtocol #3

Closed lopter closed 7 years ago

lopter commented 7 years ago

I believe this was the intention all along and allows you to properly call disconnect (and close the underlying transport) on the SerialOSC instance returned by create_serialosc_connection.

This goes in hand with 2efb3a9c93e8b5d8bbe737c67185a3ef25f6cc4d on aiosc.

lopter commented 7 years ago

As discussed over email, the intention is to really call serialosc.transport.close (serialosc being an instance of pymonome.SerialOSC) and I just had the wrong appreciation of the code.

Thank you for your help Artem! Hopefully I'll release the little code I have before this week-end.