artginzburg / MiddleClick-Sonoma

 "Wheel click" with three-finger click/tap for Trackpad and Magic Mouse.
GNU General Public License v3.0
1.6k stars 89 forks source link

An option for either — both tap and click. #17

Open hamarb123 opened 4 years ago

hamarb123 commented 4 years ago

I would like an option so that it registers both taps and clicks. Thank you. I want this as I can click like this using the setting found at System Preferences > Trackpad > Point & Click > Tap to click. I don't mind if it's a seperate option or if the app just reads that setting from System Preferences.

artginzburg commented 2 years ago

For me, the tap option registers both taps and clicks.

About possible solutions:

  1. I suppose the two options need to be merged into one and renamed to "Tap to click" if we want to match both the current code logic and the system preferences logic.

  2. Or instead we can just leave the interface as is, and change the code logic a bit so that the user can have either only tap or only click or both. But that does not resemble System Preferences, and might be too much configuration for such a small utility.

I really like the first solution because it's intuitive. I'll also research the possibility of reading the setting from System Preferences.

hamarb123 commented 1 year ago

Thanks for implementing this, It doesn't seem to work quite how I'd expect. When 'tap to click' is disabled, 3 finger click works (as expected), and tapping doesn't (as expected). But when it's enabled, 3 finger tap works (as expected), but 3 finger click registers a left click first and then a middle click. I noticed this naturally first, and then confirmed the precise click events using my testing app (https://github.com/hamarb123/mc-121772-examplefix). Here's the mouse input events it showed:

image

When tap to click is disabled, the app shows the expected output for clicking with 3 fingers:

image

(this is also the output it shows for tapping with tap to click enabled).

artginzburg commented 1 year ago

Just to know if it's related to another issue, do you have anything related to 3-finger gestures enabled in the system, like 3-finger dragging?

hamarb123 commented 1 year ago

I usually have all the settings enabled on this setting page (except app exposé), but it still reproduces with these settings (which has all the 3-finger settings disabled):

image
davepivonka commented 1 year ago

@artginzburg I had the same issue as @hamarb123 and checked the settings page from their screenshot. But in the end, it was three-finger dragging, which is in a different section of the settings (System Settings > Accessibility > Pointer Control > Trackpad Options). The problems immediately stopped so I assume it may have been their case, as well.

But because I don't want to always force click to drag anything, and the other dragging options are too inconvenient, I set the middle click to 4 fingers, which is less convenient but still works. I assume there wouldn't be a way for you to make the 3-finger middle click compatible with dragging?

I guess it would require the dragging feature to be added to this app, where a tap would translate to a middle click and holding longer or moving the cursor would turn it into a regular left-click hold. Take it as a feature suggestion :) (I don't know how difficult it would be to add, but I believe a lot of people would appreciate it as a togglable option)

hamarb123 commented 1 year ago

I don't have that option enabled (I didn't even know about it 😆), but I still have the issue where if "tap to click" is enabled it performs a left click first when I do a 3 finger click, I currently just leave it disabled and don't tap with 3 fingers.

khesed commented 1 year ago

But when it's enabled, 3 finger tap works (as expected), but 3 finger click registers a left click first and then a middle click.

Same issue still present in Sonoma.

three-finger dragging, which is in a different section of the settings (System Settings > Accessibility > Pointer Control > Trackpad Options). The problems immediately stopped so I assume it may have been their case, as well.

Problem persists on Sonoma even with these changes.

ryerrappa commented 6 months ago

Just to know if it's related to another issue, do you have anything related to 3-finger gestures enabled in the system, like 3-finger dragging?

@artginzburg I have been facing the same issue. Happens with 3 finger drag enabled. The problem goes away when I disable 3 finger drag