search

artginzburg / MiddleClick-Sonoma

 "Wheel click" with three-finger click/tap for Trackpad and Magic Mouse.
GNU General Public License v3.0
1.47k stars 85 forks source link

Fix device added callback #54

Closed karlhorky closed 1 year ago

karlhorky commented 1 year ago

Ref: https://github.com/artginzburg/MiddleClick-BigSur/issues/28#issuecomment-1337576496

Switches CFRelease to IOObjectRelease to fix callback when new devices added, which was broken in 5aca15

Reproduction:

  1. Connect Magic Mouse
  2. Start MiddleClick.app -> ✅ Middle click functionality works
  3. Turn Magic Mouse off and then turn it on again
  4. 💥 Middle click functionality broken

Before:

Screenshot 2022-12-05 at 16 30 24

After:

Screenshot 2022-12-05 at 16 27 03

karlhorky commented 1 year ago

Thanks for the merge @artginzburg ! Will this be a part of a new release 2.6.0 (non pre-release) or 2.6.0.1?

artginzburg commented 1 year ago

Of course! Sorry for the delay. I'll try to release it really soon.

karlhorky commented 1 year ago

No worries, thanks :)

karlhorky commented 1 year ago

Great, looks like my patch is included in 2.6.1 (already available in Homebrew), thanks for the release and Homebrew bump!