search

artgris / FileManagerBundle

FileManager is a simple Multilingual File Manager Bundle for Symfony
MIT License
171 stars 89 forks source link

Remove sensio/framework-extra-bundle dependency. #114

Closed czachor closed 1 year ago

czachor commented 1 year ago

Remove deprecated sensio/framework-extra-bundle dependency. See issue #113. Source: https://github.com/sensiolabs/SensioFrameworkExtraBundle

czachor commented 1 year ago

I had to add the package doctrine/annotations ^1.14. Anyway since v2.0, the AnnotationRegistry::registerLoader method is removed and since 1.8 deprecated. The package symfony/framework-bundle is also required.

artgris commented 1 year ago

thx @czachor :+1:

Ishadijcks commented 1 year ago

Awesome thanks!

pfpro commented 1 year ago

Thanks!

After upgrading to the latest release by running "composer up", sensio/framework-extra-bundle was still in my composer.json. I had to run "composer remove sensio/framework-extra-bundle" manually. Is this the desired bevaviour, or could this be improved?

czachor commented 1 year ago

Maybe it is needed by another package? In my case, the package was completely removed. In another project it remained as a dependency I guess for symfony maker "make:crud" command (not sure).

pfpro commented 1 year ago

you were right - in my case it was the isGranted annotation, which i replaced now by the symfony 6.2 approach. thanks for the feedback