Removing polluting console logs always shown

arthenica / ffmpeg-kit

FFmpeg Kit for applications. Supports Android, Flutter, iOS, Linux, macOS, React Native and tvOS. Supersedes MobileFFmpeg, flutter_ffmpeg and react-native-ffmpeg.

https://arthenica.github.io/ffmpeg-kit

GNU Lesser General Public License v3.0

4.52k stars 603 forks source link

Removing polluting console logs always shown #1045

Open dprevost-LMI opened 2 months ago

dprevost-LMI commented 2 months ago

Description

Some console logs are always shown when using the library, which is polluting our logs and is not necessary. To not output some undesired logs, I remove one occurrence and hide the second under logLevel=debug

In our project, I see the following:

See suggested changes in this PR

tanersener commented 3 weeks ago

We use these lines to troubleshoot library load issues; not seeing the 'Loaded ...' message confirms a problem with the plugin.

The changes proposed in the PR remove these lines, and the if(logLevel === "debug") { check is always false, there's no way to enable it since these lines are the plugin’s first method calls. I’ll have to reject the PR, as it would make it harder to troubleshoot native library loading issues.

dprevost-LMI commented 3 weeks ago

Interesting; if I change that for a disabled flag, would my PR be rejected again?