search

arthenica / ffmpeg-kit

FFmpeg Kit for applications. Supports Android, Flutter, iOS, Linux, macOS, React Native and tvOS. Supersedes MobileFFmpeg, flutter_ffmpeg and react-native-ffmpeg.
https://arthenica.github.io/ffmpeg-kit
GNU Lesser General Public License v3.0
4.04k stars 546 forks source link

Update ffmpeg to v5 #384

Closed noma4i closed 2 years ago

noma4i commented 2 years ago

Apple uses Dolby Vision for HDR so ffmpeg v4.4 doesn't support Apple Graphics (SMC) encoder. So once I will try to do any manipulation with a video captured with the iPhone it will end up with washed out colors. Before SMC been introduced the only one way was to use tonemap.

Describe the solution you'd like Solution is to use ffmpeg v5. https://github.com/FFmpeg/FFmpeg/blob/master/Changelog#L21

Platform It's a solution to fix Apple iOS.

tanersener commented 2 years ago

4.5.1 release of ffmpeg-kit is almost equivalent to ffmpeg v5.0. ffmpeg-kit 4.5.1 was taken from master only 1 week before ffmpeg 5.0 was cut.

Besides, if you want to have the latest updates from ffmpeg, you always have the option to build your own ffmpeg-kit library with ffmpeg version you need. This line defines ffmpeg version used by build scripts. If you update it build scripts will download it during compilation.

noma4i commented 2 years ago

@tanersener I can fork it for a while but would be nice to have it updated in the lib

tanersener commented 2 years ago

As I said in my comment, ffmpeg-kit 4.5.1 is almost the same as ffmpeg 5.0. I suggest checking if the encoder/filter you want to use is there first.