search

arthenica / ffmpeg-kit

FFmpeg Kit for applications. Supports Android, Flutter, iOS, Linux, macOS, React Native and tvOS. Supersedes MobileFFmpeg, flutter_ffmpeg and react-native-ffmpeg.
https://arthenica.github.io/ffmpeg-kit
GNU Lesser General Public License v3.0
4.44k stars 594 forks source link

React native new architecture #557

Open arasrezaei opened 2 years ago

arasrezaei commented 2 years ago

Hello, thank you for this great library, As you know, this library has a huge size and greatly impacts startup performance. I want to know are there any plans importing it into turbomodules (new react native architecture)

Thanks.

tanersener commented 2 years ago

Could you elaborate how turbo modules will decrease the size of the library?

arasrezaei commented 2 years ago

Could you elaborate how turbo modules will decrease the size of the library?

It will not decrease it, but it will load the module on demand and will not load the module on start up so, the app will start fast... Also JS communicates with native directly through JSI rather than slow serialization bridge... New architecture reduces apps size a bit though (not sure)

tanersener commented 2 years ago

We want to migrate the React Native plugin to TurboModules but we don't have a due date for it. It's not something we are looking at the moment. We are open for PRs though.

jobpaardekooper commented 4 weeks ago

Starting from react-native 0.76 the new architecture will become the standard moving forward. It would really be great if the RN library was updated so it will stay compatible with future versions of RN.