search

arthepsy / pan-globalprotect-okta

PaloAlto Networks GlobalProtect VPN (integrated with OKTA) command-line client
101 stars 42 forks source link

Support push factor #14

Closed sirmax closed 4 years ago

sirmax commented 5 years ago

Closes #6

I've added simple push factor support, roughly as described in https://developer.okta.com/blog/2018/06/22/multi-factor-authentication-command-line#okta-verify-push-notification

Since I'm not a python dev my code might require some cleanup, but at least a success path seems to be working.

trams commented 4 years ago

Great patch. I just test it on my linux machine and it worked like a charm I just discovered a problem with second factor priorities which I fixed here https://github.com/trams/pan-globalprotect-okta/commit/3949d4d4c062171a5f310b515a227a2755c1a3d2

Also I want to become a maintainer for this project unless someone already took this responsibility on themselves.

coldcoff commented 4 years ago

I also brought it to my branch, so that it is in PR #19

sirmax commented 4 years ago

@coldcoff that's great. I'm closing this PR in favour of your #19