search

arthepsy / pan-globalprotect-okta

PaloAlto Networks GlobalProtect VPN (integrated with OKTA) command-line client
101 stars 42 forks source link

Don't try to split a tuple for debug output #31

Open keis opened 2 years ago

keis commented 2 years ago

Add tuple to the list of types that should not be split()

arthepsy commented 2 years ago

LGTM. Anyhow, can You elaborate in what situation this happens?

keis commented 2 years ago

It happens when trying to use webauthn with debug on

!!! Touch the flashing U2F device to authenticate... !!!
Traceback (most recent call last):
  File "/home/keis/src/github.com/arthepsy/pan-globalprotect-okta/./gp-okta.py", line 660, in okta_mfa_webauthn
    dbg(conf.debug, 'assertion.result', result)
  File "/home/keis/src/github.com/arthepsy/pan-globalprotect-okta/./gp-okta.py", line 130, in dbg
    for line in x.split('\n'):
AttributeError: 'tuple' object has no attribute 'split'

This is with fido2==0.7.0 so before the API change that's mentioned in #33

coldcoff commented 2 years ago

@arthepsy: That change is good. It's useful for #33 but unrelated.

coldcoff commented 2 years ago

@arthepsy -- please merge.