Closed jtesta closed 4 years ago
I'd love to fix the failing test, but I'm not sure how to run them locally. Any hints?
@arthepsy ping
@jtesta sorry for not getting back sooner. Will reply in few hours.
@arthepsy re-ping
@arthepsy So, uhh... hi. Its been over a year, and this hasn't been merged.
Are you still interested in maintaining this project? If not, I'd be happy to take over as maintainer!
And another year has passed :confused:
This PR adds RSA key size checking (for both stand-alone host keys AND those in certificates), as well as Diffie-Hellman group exchange modulus tests (solves issues #19 and #24). Moduli found to be less than 2,048-bits are flagged.
Example results:
Additional certificate tests can be added in the future, such as principle matching checks, and validation of time ranges. If there's interest in the obsolete "ssh-rsa-cert-v00@openssh.com" host key type, that can be added as well (this PR only handles the newer "ssh-rsa-cert-v01@openssh.com" type).
Unfortunately, I've run out of time, and can't get to fixing the mypy errors introduced. That probably isn't too hard, though, for someone familiar with mypy.