Add cross reference handling, improve error handling

arthur-debert / google-code-issues-migrator

A simple script to migrate issues from google code to github.

67 stars 56 forks source link

Add cross reference handling, improve error handling #18

Closed tfmorris closed 11 years ago

tfmorris commented 12 years ago

The changes in my fork do the following:

abort if there's an error getting the existing issues. Failing to do so can lead to the creation of duplicates.
changed existing issues has to use the original Google Code issue number instead of the title to deal with a) duplicate titles and b) titles that change of the GC side NOTE: this may not be backward compatible if the link hasn't always been included or the format of it changed !!
escaped # signs so they don't get interpreted as issue references
convert Google Code style Issue nnn xrefs to Github style xrefs NOTE: this is incomplete! It works for a clean repo where there's a one to one mapping between issue numbers, but needs extension to support non 1:1 mappings.

joelpt commented 12 years ago

I'll process this in a few days. The main branch has diverged significantly from the branch you have modified so I want to make sure everything gels there. I'd also like to add compatibility code so that old-vs-new-style issues don't create duplicates during repeated migrations. Of course you're also welcome to do the same :)

tfmorris commented 12 years ago

I can update against the master. I hadn't realized they'd diverged that far. Compatibility is beyond my ken though, so I'll leave you to deal with that.

tfmorris commented 11 years ago

Wow, there sure are a lot gratuitous changes in there. Did they really think it was that important to change your single quotes to double quotes and add blank lines everywhere? Anyway, I've started the merge. I need to take a break for a few hours, but should have the merge completed later today.

tfmorris commented 11 years ago

Everything has been merged. I was going to add support for Milestones too, but I've moved on to other things.

marciomazza commented 11 years ago

I have some small corrections to add. I will wait for this to be merged to make my pull request.

danielniccoli commented 11 years ago

Arthur, put a little love into your pull requests, please.

joelpt commented 11 years ago

Apologies for the delayed pull. Looks great, thanks for the work.