arthur-e / Wicket

A modest library for moving between Well-Known Text (WKT) and various framework geometries
https://arthur-e.github.io/Wicket/
Other
586 stars 226 forks source link

Travis CI build fails tests that pass locally #123

Closed arthur-e closed 6 years ago

arthur-e commented 6 years ago

npm test locally will pass all the tests but the Travis CI build is still failing (below excerpted from second half of tests; see package.json):

START:
25 02 2018 14:03:34.301:INFO [karma]: Karma v1.7.1 server started at http://0.0.0.0:9877/
25 02 2018 14:03:34.303:INFO [launcher]: Launching browser PhantomJS with unlimited concurrency
25 02 2018 14:03:34.309:INFO [launcher]: Starting browser PhantomJS
25 02 2018 14:03:34.560:INFO [PhantomJS 2.1.1 (Linux 0.0.0)]: Connected on socket _Vgs4ftJAT-qwdPCAAAA with id 82904768
  Standard WKT Test Cases: 
    ✖ encountered a declaration exception
Finished in 0.039 secs / 0 secs @ 14:03:34 GMT+0000 (UTC)
SUMMARY:
✔ 0 tests completed
✖ 1 test failed
FAILED TESTS:
  Standard WKT Test Cases: 
    ✖ encountered a declaration exception
      PhantomJS 2.1.1 (Linux 0.0.0)
    ReferenceError: Can't find variable: google in tests/wicket-gmap3-spec.js (line 13)
    tests/wicket-gmap3-spec.js:13:28
    global code@tests/wicket-gmap3-spec.js:1:9
npm ERR! Test failed.  See above for more details.

Thoughts:

ffflabs commented 6 years ago

The main problem comes from PhantomJS being unable to load google maps API from an https resource. I'll create a PR to fix this.

arthur-e commented 6 years ago

Fixed in recent PR.