Closed ffflabs closed 6 years ago
@arthur-e I'm still unsure if it was a good idea to remove google.maps.api key. It's a key I use for tests and examples in Stack Overflow, and I'm comfortable enough making it public. It's still your call tho.
This is great! Dream come true. Thanks for fixing the tests for Travis CI.
Re: API key, it sounds like I should register one that is dedicated to Wicket and apply it.
This fixes the error reported in issue https://github.com/arthur-e/Wicket/issues/123
Currently, PhantomJS isn't able to load
https
resources unless you pass the flag--ignore-ssl-errors=true
. Therefore, the config inkarma.conf.js
has a new section to configure PhantomJS:(The other approach would be to request google maps API using
http
instead ofhttps
, but we don't know if they would support that protocol in the long term).I also pinned
google.maps.api
version to3.31
(current stable) because3.32
(3.exp) adds a new renderer and base map that will be subject to several changes soon, so why take the risk now.The test file
wicket-gmap3-spec.js
has now atestAsync
function:This condition is checked declaring
beforeEach
And we add an assertion to ensure
google.maps
is loaded: