search

arthur-e / Wicket

A modest library for moving between Well-Known Text (WKT) and various framework geometries
https://arthur-e.github.io/Wicket/
Other
586 stars 226 forks source link

replace global esri deps with AMD #75

Closed steveoh closed 7 years ago

steveoh commented 8 years ago

refs #74

in case you don't want to choose one or the other.

ffflabs commented 8 years ago

but... you still need to have a mapping to esri/* declared beforehand, or a local copy of those files (I don't know if ESRI provides those or is it CDN only) plus you now need to have an AMD loader in the global scope.

arthur-e commented 8 years ago

We don't have any tests written for the ESRI integration. Can anyone confirm whether or not this pull request is backwards compatible? Thanks!

steveoh commented 8 years ago

@amenadiel the js api is on bower and dojo provides an amd loader in the global scope. If you are using dojo or the esri api, which is built on top of dojo, then you already have a loader (require) in global scope.

molekilla commented 7 years ago

hi, this works very well with ESRI 4.1, I'll use the commit until a new release is cut.

arthur-e commented 7 years ago

Great, thanks!