search

arthurbergmz / webpack-pwa-manifest

Progressive Web App Manifest Generator for Webpack, with auto icon resizing and fingerprinting support.
MIT License
513 stars 93 forks source link

refactor(jimp): update jimp to fix minimist vulnerability #122

Closed Den-dp closed 4 years ago

Den-dp commented 4 years ago

closes #121

hc-12 commented 4 years ago

Can we merge this PR?

rajatb-git commented 4 years ago

Been waiting for this fix... when will this be merged?

Den-dp commented 4 years ago

It would be nice if @arthurbergmz or @doug-wade looked at this PR.

But I would say that we are blocked with #119 🤷‍♂️

bcanseco commented 4 years ago

Checked out @Den-dp's fork - all tests passed. Used it in one of my projects and images are processed as expected. Bumping for a wishful merge 🙏

Den-dp commented 4 years ago

I decided to go with publishing this fix from my own fork. For that I want to configure npm publishing from a master branch (b/c this is how semantic-release package works), but unfortunately this PR was provided via master branch too 🤦. So have to close it on order to add some configuration for publishing.

bcanseco commented 4 years ago

@Den-dp Please link the npm package once it's published, I'd be interested in using it too 👍

Den-dp commented 4 years ago

So I released a fix from my fork https://github.com/Den-dp/webpack-pwa-manifest/releases/tag/v4.2.1 🙌

https://www.npmjs.com/package/webpack-pwa-manifest-contrib

You can install it via:

npm i webpack-pwa-manifest-contrib@4.2.1 -D

Please notice the new name with -contrib at the end, and make sure to change require('webpack-pwa-manifest-contrib') in webpack.config.js.

Stanzilla commented 4 years ago

@Den-dp nice! are you planning to integrate more of the open pull requests from here? maybe try posting in https://github.com/arthurbergmz/webpack-pwa-manifest/issues/119 as well so @arthurbergmz could give you permissions on here?