Closed strootje closed 6 months ago
Apparently a dependency from the terser-webpack-plugin dropped node 8/9 support: https://github.com/sindresorhus/p-limit/commit/b35faf54fb0871d9ae592069a18083a2ba15d8a9
html-webpack-plugin
now has a 5.x series out of alpha FYI
Is there anything stopping this from merging?
I'm also waiting on the Typing updates eagerly 😄
@arthurbergmz Is there any chance to merge this PR? If you're not comfortable pulling an alpha version of html-webpack-plugin
and if @strootje is no longer available I'd be happy to update the PR to use html-webpack-plugin
5.3.1
I've updated the html-webpack-plugin
and the webpack
package to their latest versions.
@arthurbergmz any chance to review / complete this?
+1
I try install your branch, but I get error.
npm uninstall webpack-pwa-manifest && npm install strootje/webpack-pwa-manifest#update-webpack-v5 --save-dev
[webpack-cli] Failed to load '/app/webpack.config.js' config
[webpack-cli] Error: Cannot find module './dist/index.js'
Require stack:
- /app/node_modules/webpack-pwa-manifest/index.js
- /app/webpack.config.js
- /app/node_modules/webpack-cli/lib/webpack-cli.js
- /app/node_modules/webpack-cli/lib/bootstrap.js
- /app/node_modules/webpack-cli/bin/cli.js
- /app/node_modules/webpack/bin/webpack.js
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:880:15)
at Function.Module._load (internal/modules/cjs/loader.js:725:27)
at Module.require (internal/modules/cjs/loader.js:952:19)
at require (/app/node_modules/v8-compile-cache/v8-compile-cache.js:159:20)
at Object.<anonymous> (/app/node_modules/webpack-pwa-manifest/index.js:1:80)
at Module._compile (/app/node_modules/v8-compile-cache/v8-compile-cache.js:192:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
at Module.load (internal/modules/cjs/loader.js:928:32)
at Function.Module._load (internal/modules/cjs/loader.js:769:14)
at Module.require (internal/modules/cjs/loader.js:952:19) {
code: 'MODULE_NOT_FOUND',
requireStack: [
'/app/node_modules/webpack-pwa-manifest/index.js',
'/app/webpack.config.js',
'/app/node_modules/webpack-cli/lib/webpack-cli.js',
'/app/node_modules/webpack-cli/lib/bootstrap.js',
'/app/node_modules/webpack-cli/bin/cli.js',
'/app/node_modules/webpack/bin/webpack.js'
]
}
I try install your branch, but I get error.
I just tried installing my branch as well and for me it is working. Can you maybe provide more info as to what you are trying.
For anybody trying to get this package to work install it like this: npm install strootje/webpack-pwa-manifest#update-webpack-v5
. This will grab the version from github and build it on the spot.
@arthurbergmz a review would be nice.
I try install your branch, but I get error.
npm uninstall webpack-pwa-manifest && npm install strootje/webpack-pwa-manifest#update-webpack-v5 --save-dev
[webpack-cli] Failed to load '/app/webpack.config.js' config [webpack-cli] Error: Cannot find module './dist/index.js' Require stack: - /app/node_modules/webpack-pwa-manifest/index.js - /app/webpack.config.js - /app/node_modules/webpack-cli/lib/webpack-cli.js - /app/node_modules/webpack-cli/lib/bootstrap.js - /app/node_modules/webpack-cli/bin/cli.js - /app/node_modules/webpack/bin/webpack.js at Function.Module._resolveFilename (internal/modules/cjs/loader.js:880:15) at Function.Module._load (internal/modules/cjs/loader.js:725:27) at Module.require (internal/modules/cjs/loader.js:952:19) at require (/app/node_modules/v8-compile-cache/v8-compile-cache.js:159:20) at Object.<anonymous> (/app/node_modules/webpack-pwa-manifest/index.js:1:80) at Module._compile (/app/node_modules/v8-compile-cache/v8-compile-cache.js:192:30) at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10) at Module.load (internal/modules/cjs/loader.js:928:32) at Function.Module._load (internal/modules/cjs/loader.js:769:14) at Module.require (internal/modules/cjs/loader.js:952:19) { code: 'MODULE_NOT_FOUND', requireStack: [ '/app/node_modules/webpack-pwa-manifest/index.js', '/app/webpack.config.js', '/app/node_modules/webpack-cli/lib/webpack-cli.js', '/app/node_modules/webpack-cli/lib/bootstrap.js', '/app/node_modules/webpack-cli/bin/cli.js', '/app/node_modules/webpack/bin/webpack.js' ] }
@icetee Same issue. Did you solve it?
This PR fixes some typing errors for webpack and updated the html-webpack-plugin to v5 (alpha). Also fixes a deprecation error with webpack. (see #144)