search

arthurbergmz / webpack-pwa-manifest

Progressive Web App Manifest Generator for Webpack, with auto icon resizing and fingerprinting support.
MIT License
514 stars 93 forks source link

Favicon injection and favicons-webpack-plugin #85

Open mkvlrn-cm42 opened 6 years ago

mkvlrn-cm42 commented 6 years ago

I successfully generated a PWA manifest and all there's left to do is link the icons in my html.

After finding #22 and #41 I got a bit confused: it seems I would have to use favicons-webpack-plugin to generate and inject the links to the generated icons in my html, but I don't get how the icons will then be listed in the manifest generated by this plugin.

I thought 4.0.0 was coming soon, and proper favicon support would be there, but then I found #70, and it may not be the case.

TL;DR: Should I not generate icons using this plugin? If not, how do I automatically reference the icons in the generated manifest when they are created by another plugin?

Edit: it seems favicons-webpack-plugin is abandoned. I really would like to use only one package to automate my manifest/icons, and this one here feels like it's faster and well organized, but not having the icons injected in the html is an issue.

evdama commented 5 years ago

any updates on this i.e. how do people inject their icons? manually still?

jalik commented 5 years ago

I also think that using one plugin to generate icons + manifest and injecting them into the HTML is the way to go ! since this plugin is already generating icons and manifest, maybe it's not a big deal to also inject favicons in the HTML ?