arthurbolsoni / Purple-adblock

Adblock for the twitch using server side signature
GNU General Public License v3.0
468 stars 27 forks source link

Getting pre-roll ads on Twitch #59

Closed 32423d closed 1 year ago

32423d commented 1 year ago

I am on the latest version of the extension and I am getting pre-roll ads on Twitch. This issue started occurring today. The same channels with pre-roll ads today didn't have pre-roll ads yesterday so I am not sure if this is an issue that randomly occurs or if it will be reoccurring in the future.

Suprcheese commented 1 year ago

I've also noticed this happen starting today.

arthurbolsoni commented 1 year ago

this will happen sometimes. this happens because while the script is loading, a stream loads first. but after 1-2sec the ad is blocked

arthurbolsoni commented 1 year ago

https://github.com/arthurbolsoni/Purple-adblock/issues/60#issuecomment-1416808161

Bun01294 commented 1 year ago

I'm getting prerolls but if i reset the player its permanently gone, i also get buffering issues and have to reset, but a few mins they're all gone. I'm not getting the "1-2sec the ad is blocked"

eldepor commented 1 year ago

I'm having ads with 2.5.1 tempermonkey script. So I switched back to 2.5.0.9 and it's working perfectly.

Bun01294 commented 1 year ago

i'll try that and see what happens.

Bun01294 commented 1 year ago

I'm having ads with 2.5.1 tempermonkey script. So I switched back to 2.5.0.9 and it's working perfectly.

Are you using chrome? i can't get to work in firefox. and i think the unsigned xpi only works in the developer edition

eldepor commented 1 year ago

I'm having ads with 2.5.1 tempermonkey script. So I switched back to 2.5.0.9 and it's working perfectly.

Are you using chrome? i can't get to work in firefox. and i think the unsigned xpi only works in the developer edition

Yes. But I'm using the script version with tampermonkey, not the extension version.

https://github.com/arthurbolsoni/Purple-adblock/raw/63cbfa3d31778123df2eb6b017bf948a05f69421/tampermonkey/dist/purpleadblocker.user.js

Bun01294 commented 1 year ago

Cool, installed it then, and i'll see if i don't run into any issues

Bun01294 commented 1 year ago

It was working but got infinite black loading screen and buffers, feels like twitch is watching us. I'm going to bed i'll do this later in the afternoon

eldepor commented 1 year ago

That's weird man, I ain't getting any issues, works beautifully. Have you disabled any other twitch ad block, script, etc and use just the one from the link in Tampermonkey?

Bun01294 commented 1 year ago

That's weird man, I ain't getting any issues, works beautifully. Have you disabled any other twitch ad block, script, etc and use just the one from the link in Tampermonkey?

I disabled all other extensions in firefox and i still have buffer issues, black screen and somehow an ad would appear. I tried to test it on chrome byself with no extensions and same issue sadly. The newer version work but the crappy pre-roll would leak but only once as it disappears permanently with resetting player but every time i hop into a different streamer.

Bun01294 commented 1 year ago

It just the pre-roll issue that i have with the 2.5.1/2.5.3 that i only have, i don't want to manually reset every time, everything else works perfectly

eldepor commented 1 year ago

Pls try this one, I put the wrong link before

https://github.com/arthurbolsoni/Purple-adblock/raw/63cbfa3d31778123df2eb6b017bf948a05f69421/tampermonkey/dist/purpleadblocker.user.js

no pre rolls, buffers, no nothing in Firefox too

Bun01294 commented 1 year ago

Its still the same one, i still have the same issues. You using any other scripts/setups? I thinik that twitch is using different settings for different users. With the 2.5.0.9 you gave i only get to the infinite black screen

eldepor commented 1 year ago

Its still the same one, i still have the same issues. You using any other scripts/setups? I thinik that twitch is using different settings for different users. With the 2.5.0.9 you gave i only get to the infinite black screen

:( Nope, just a fresh install of Firefox on W7. I remember I had that infinite black screen issues with other tw. adbl. extensions and scripts. Others still gave me ads. So I deleted all of them and installed just this script, which is the one that works best for me. :S

arthurbolsoni commented 1 year ago

Are you using chrome? i can't get to work in firefox. and i think the unsigned xpi only works in the developer edition

Do the following: disable all your browser extensions (leave only the tampermonkey script); go to a stream where the problem occurs; press "F12" go to the "console" tab; there will be many logs. copy or take a print where you can see everything. and send it here or on discord. so I can know where the script is giving error to be able to solve it

Bun01294 commented 1 year ago

buffer and infinite black loading screen.zip One for the crazy buffer it does, the stream starts to lag and the other one is the loading screen issue. I'm using 2.5.0.9 the files are txt btw i used notepad ++ to open it

arthurbolsoni commented 1 year ago

https://github.com/arthurbolsoni/Purple-adblock/issues/79