search

arthurbolsoni / Purple-adblock

Adblock for the twitch using server side signature
GNU General Public License v3.0
458 stars 27 forks source link

stopped working today #60

Closed thisisdumbstuff closed 1 year ago

thisisdumbstuff commented 1 year ago

stopped working today, some streams just show offline banner even though streamer is live and online. disable this extension and it works fine. using chrome

kevin-wellinger commented 1 year ago

confirm this. sound works for me after 20-30 seconds, but the stream is displayed as offline.

workaround:

they added 2 new elements in "video-player__overlay", remove these:

Screenshot 2023-01-25-182620

mrtysn commented 1 year ago

@kevin-wellinger if you could provide some more detail, I would be willing to work on a PR

arthurbolsoni commented 1 year ago

There may be some "ghost ads" when loading the stream. but are blocked after 1-2 seconds. give me feedback if it's acceptable or it's better to leave a black screen during this time. or maybe even a custom logo in that time. https://github.com/arthurbolsoni/Purple-adblock/releases/tag/2.5.1

RandomErrorMessage commented 1 year ago

Assuming blacking out the ad isn't a giant hacky workaround that would bloat up the code, I'd opt for that instead of displaying the first several seconds. Showing an advertisement, even for 2 seconds, is a form of assault and I instinctively race to close the window to defend myself from this audiovisual attack.

eldepor commented 1 year ago

https://github.com/arthurbolsoni/Purple-adblock/issues/59#issuecomment-1421993379

arthurbolsoni commented 1 year ago

https://github.com/arthurbolsoni/Purple-adblock/issues/79