Closed unho closed 5 years ago
@arthurdejong Any idea why this is failing?
@unho There are a few issues that can be seen from the build logs:
Furthermore, can you look into the following changes:
site:nz
). It would be really nice to have a dozen or so extra numbers that can be checked.calc_check_digit()
to return a string instead of an integer to match the other implementations?remainder = total % 11
return 0 if remainder == 0 else 11 - remainder
bit in the _calculate_digit()
function can be replaced by
return -total % 11
(or even integrated into the sum()
line to make it a single expression.
@arthurdejong I've made several of the suggested changes and Travis now passes. I left out removing blank lines as IMHO that seriously compromises readability. I also did not look for more examples to test. Regarding adding more information in the docs I am not sure which information to put there.
I've merged your PR as 7211ccb with a few changes. Thank you for your contribution.
Thanks for merging the changes, despite I still think that those changes compromised code readability.
There are two other PRs wanting to be landed :-)
Fixes issue #104.