arthurdejong / python-stdnum

A Python library to provide functions to handle, parse and validate standard numbers.
https://arthurdejong.org/python-stdnum/
GNU Lesser General Public License v2.1
498 stars 206 forks source link

Add New Zealand IRD number #112

Closed unho closed 5 years ago

unho commented 5 years ago

Fixes issue #104.

unho commented 5 years ago

@arthurdejong Any idea why this is failing?

arthurdejong commented 5 years ago

@unho There are a few issues that can be seen from the build logs:

Furthermore, can you look into the following changes:

unho commented 5 years ago

@arthurdejong I've made several of the suggested changes and Travis now passes. I left out removing blank lines as IMHO that seriously compromises readability. I also did not look for more examples to test. Regarding adding more information in the docs I am not sure which information to put there.

arthurdejong commented 5 years ago

I've merged your PR as 7211ccb with a few changes. Thank you for your contribution.

unho commented 5 years ago

Thanks for merging the changes, despite I still think that those changes compromised code readability.

There are two other PRs wanting to be landed :-)