search

arthurdejong / python-stdnum

A Python library to provide functions to handle, parse and validate standard numbers.
https://arthurdejong.org/python-stdnum/
GNU Lesser General Public License v2.1
498 stars 206 forks source link

Add single method to check any VAT number #199

Closed unho closed 4 years ago

unho commented 4 years ago

This effectively mimics vatnumber's check_vat function, so people can easily replace the outdated vatnumber library with stdnum.

unho commented 4 years ago

@arthurdejong Ready for review.

arthurdejong commented 4 years ago

I would rather have the module have the same signature as other validation modules (having compact(), validate() and is_valid() functions.

For an example, see the stdnum.eu.vat module. You can also use the get_cc_module() from stdnum.util to avoid the extra external dependency.

arthurdejong commented 4 years ago

Hi @unho, I've created ff188bd based on your PR with some changes as described earlier. Thanks!

unho commented 4 years ago

Thanks @arthurdejong I am sorry I didn't had time to do it myself.

arthurdejong commented 4 years ago

No worries, so much to do, so little time ;)