Add support for Taiwan TIN number

arthurdejong / python-stdnum

A Python library to provide functions to handle, parse and validate standard numbers.

https://arthurdejong.org/python-stdnum/

GNU Lesser General Public License v2.1

498 stars 206 forks source link

Add support for Taiwan TIN number #214

Closed unho closed 4 years ago

unho commented 4 years ago

Fixes #209.

unho commented 4 years ago

I am not sure why Travis fails.

pokoli commented 4 years ago

@unho Travis is failing when building the docs beucause there is a warning on it:

/home/travis/build/arthurdejong/python-stdnum/docs/stdnum.in_.aadhaar.rst:2:Unknown target name: "stdnum.in".

You should fix it to make travis happy.

arthurdejong commented 4 years ago

Hi @unho I've merged your PR as dab926c with a minor change: I've renamed calc_check_digit() to calc_checksum() because that is what it really did (it would not calculate the correct check digit for an arbitrary number). Thanks!

unho commented 4 years ago

@arthurdejong Thanks! Not sure when you are going to proceed with next release. I would like to also include PR #199 in next release, which is still work in progress, so I will try work on it one of these days.