search

arthurdejong / python-stdnum

A Python library to provide functions to handle, parse and validate standard numbers.
https://arthurdejong.org/python-stdnum/
GNU Lesser General Public License v2.1
498 stars 206 forks source link

Li peid support #241

Closed ramsondon closed 3 years ago

ramsondon commented 3 years ago

Added support for Liechtenstein PEID (Personenidentifikationsnummer) validation

unho commented 3 years ago

Can you please squash all these commits into a single one?

unho commented 3 years ago

Please include a reference to issue #125

unho commented 3 years ago

Adjust commit message to indicate that it fixes issue #125.

arthurdejong commented 3 years ago

Hi @ramsondon,

I've merged your PR as 5082af4. Thanks for providing the format, a petty that there was no check digit.

The PEID does not appear to be the Liechtenstein VAT number so I've not merged that part.

In Liechtenstein the VAT number appears to be the Mehrwertsteuer (MWST) which seems to be 5 digits long. There also seem to be some kind of registration number that seems to start with "FL", followed by 10 digits which some sources suggest is a PEID (although the PEID can be longer?) and a single digit (perhaps a check digit?). There also seems to be a Legal Entity Identifier (LEI), Unternehmensnummer and Firmennummer but some of these could refer to the same number.

unho commented 3 years ago

@arthurdejong it looks like you have not picked the format implementation. I am curious about the reason?

arthurdejong commented 3 years ago

I generally only include a format() function if it changes anything to the number. For example if numbers have commonly used separators in certain places but they are more or less optional the format() function would return a number that includes the separators. If it doesn't add anything I leave it out because it is less code to maintain (albeit very little).

ramsondon commented 3 years ago

Thx for merging... happy to have the peid now in the package!