search

arthurdejong / python-stdnum

A Python library to provide functions to handle, parse and validate standard numbers.
https://arthurdejong.org/python-stdnum/
GNU Lesser General Public License v2.1
495 stars 205 forks source link

Add support for XI VAT numbers in vatin #251

Closed alexis-via closed 3 years ago

alexis-via commented 3 years ago

XI VAT numbers now works well via stdnum.gb.vat, but not via stdnum.vatin This PR fixes it. I'm not familiar with the code, so check carefully. More info on #250

arthurdejong commented 3 years ago

Thanks, I've merged it as 53f13b4 with a small modification and the addition of a test.

alexis-via commented 3 years ago

Thank you very much! Would it be possible to have a new release of python-stdnum ? It would be a kind of "Brexit" release :) It's important for the software that rely on stdnum to validate VAT numbers and that must now accept VAT numbers for Northern Ireland.

alexis-via commented 3 years ago

@arthurdejong What do you think of my suggestion for a new "Brexit compliant" release of stdnum (1.16) ? If I can help make that happen, please tell me. It would be very useful for several opensource software that rely on stdnum to validate VAT numbers and now need to enter XI VAT numbers.

arthurdejong commented 3 years ago

Hi @alexis-via,

I would also like to incorporate the changes in https://github.com/arthurdejong/python-stdnum/pull/248 but I'm still waiting for a few missing bits of information. After that I will make a release. If there is no response by this weekend I'll also make a new release to not delay the brexit-changes rollout any longer.

Other than that there is not much to do. Making the release is just a matter of following by quick checklist, making release notes, signing stuff, uploading, etc.

alexis-via commented 3 years ago

OK, thanks !

arthurdejong commented 3 years ago

FYI: Release 1.16 was just made and includes this fix.

alexis-via commented 3 years ago

Thank you so much for this new release! It works great.