Norwegian orgnr validates invalid org numbers.

arthurdejong / python-stdnum

A Python library to provide functions to handle, parse and validate standard numbers.

GNU Lesser General Public License v2.1

495 stars 205 forks source link

All norwegian org numbers must be between 800_000_000 and 999_999_999, and your library validates org numbers like "100 000 008". Perhaps a better validation function would be, e.g.

def is_valid(orgnr):
    if isinstance(orgnr, str):
        orgnr = int(orgnr.replace(" ", ""))   # Strip whitespace
    elif not isinstance(orgnr, int):
        raise TypeError("orgnr must be a str or int.")
    if not 800_000_000 <= orgnr < 1_000_000_000:
        return False
    # Fast way to calculate the checksum
    weighted_sum = 0
    for weight in [1, 2, 3, 4, 5, 6, 7, 2, 3]:
        orgnr, remainder = divmod(orgnr, 10)
        weighted_sum += weight * remainder
    return not weighted_sum % 11

arthurdejong / python-stdnum

Norwegian orgnr validates invalid org numbers. #275