arthurdejong / python-stdnum

A Python library to provide functions to handle, parse and validate standard numbers.
https://arthurdejong.org/python-stdnum/
GNU Lesser General Public License v2.1
495 stars 205 forks source link

Update aadhaar.py and pan.py + Add Indian EPIC and GSTIN #279

Closed vairag22 closed 2 years ago

vairag22 commented 2 years ago
vairag22 commented 2 years ago

Took 3 bad pull requests (#276, #277, #278) but finally I'm done. It was a good learning experience though.

arthurdejong commented 2 years ago

Hi @vairag22

Thanks for your contributions.

I've merged your changes with some modifications. Specifically I reverted some of your changes to Aadhaar and PAN to maintain the current API (e.g. renamed card_holder_type to holder_type but also kept the old name to not break third-party code that relies on that).

In the GSTIN module I delegated some of the checking to the PAN module to avoid duplication.

Btw, you can easily run the tests locally with tox which should save you some time in pushing commits to test them.