Czech Bank Account Code and Number

[petrprikryl]

Hi, would it be possible to add Czech bank account codes? https://www.cnb.cz/export/sites/cnb/cs/platebni-styk/.galleries/ucty_kody_bank/download/kody_bank_CR.pdf

And Czech bank account number? https://www.penize.cz/osobni-ucty/424173-tajemstvi-cisla-uctu-klicem-pro-banky-je-11 http://www.zlatakoruna.info/zpravy/ucty/cislo-uctu-v-cr

Are you interested to integrate this if I will create PR? Thanks for the effort :wink:

[arthurdejong]

Hi @petrprikryl

Thanks for creating the issue. The bank account codes seem to be mostly a registry containing 4-digit numbers. The PDF version you linked to is not really ideal for importing into python-stdnum. In the current set-up just before creating a new release of python-stdnum the update scripts (see the update directory) are run that output the dat files in the stdnum directory. These scripts work best when using a more structured input (see e.g. update/be_banks.py which outputs data for stdnum/be/banks.dat).

If you could create a PR to implement these number formats, that would be great and I'd be willing to help get them integrated into python-stdnum.

In general:

• look at the existing similar modules (e.g. stdnum/be/iban.py, stdnum/es/ccc.py or stdnum/no/kontonr.py)
• it is important to have some basic number description and pointers to where the number is defined
• if possible (and that should be doable for bank account numbers in general) have a test set with a number of known valid numbers (I often search for valid numbers online published on contact pages, etc.)
• the more technical requirements are covered by the tests (you can run tox to run the tests but they should also be run on pull requests)

[petrprikryl]

Thanks for detailed guidance. PR is ready :wink: