search

arthurdejong / python-stdnum

A Python library to provide functions to handle, parse and validate standard numbers.
https://arthurdejong.org/python-stdnum/
GNU Lesser General Public License v2.1
484 stars 203 forks source link

Add support for Finland HETU new century indicating signs #396

Closed mjturt closed 1 year ago

mjturt commented 1 year ago

Finland's HETU updated on 2023-01-01 adding more century indicating sign options. Detailed information of the reformation can be found at the Digital and Population Data Services Agency site.

The reformation doesn't affect checksum validation, and all the old HETU's are still valid.

sirtawast commented 1 year ago

The reformation doesn't affect checksum validation, and all the old HETU's are still valid.

For non-Finnish reviewer's convenience: HETU is an acronym for personal identity code or "PIC".

Citation from Digital and Population Data Services Agency site page:

DVV’s estimation of the timetable for the introduction of new intermediate characters Situation as of 2/2023: According to the current estimate, personal identity codes with intermediate characters in line with the new intermediate character decree will be issued for the first time in April 2024.

This might be a breaking change on some code bases if merged straight away but eventually the issue should be addressed nation-wide.

arthurdejong commented 1 year ago

Thanks for providing the fix. I've merged it as 36858cc.

Since all codes are still valid I don't think this is a breaking change (at least not for python-stdnum). What is important is that python-stdnum should not reject valid numbers.

mjturt commented 1 year ago

Great, thank you! When do you plan to make a new release?

arthurdejong commented 1 year ago

I hope to find the time to review a number of the open PR soon and make a release.