arthurdent75 / SimpleScheduler

An Home Assistant AddOn to schedule entities on/off on weekly base
183 stars 36 forks source link

Add GH action to build and publish a docker image #130

Closed micw closed 9 months ago

micw commented 1 year ago

Hello,

this is a contribution to #126. It adds a github action that checks out the repo, builds the docker image and pushes it directly to github image registry.

No manual work needed, all is automated by github. It will create an image for every branch and every tag that contains this workflow file. You can restrict it to certain tags or branches via the "on...push..." conditions.

It would be nice if you'd start to git-tag versions, so that each new version gets it's own docker image.

Edit: you can see the result at https://github.com/micw/SimpleScheduler/pkgs/container/simplescheduler . Edit2: GH actions seems to have issues today. If the action falis with no error message, just re-run it.

arthurdent75 commented 1 year ago

Thank you for your contribution. I've already started to figure it out and this simplifies my work a lot. I will take a closer look, point to my docker hub account, then merge. I also think that will be useful to compile for ARMV7 besides AMD64, for those who use raspberry

micw commented 1 year ago

Please consider to use GH packages rather than docker hub. Docker hub recently did some real bad decisions that made many OSS projects turn away from them (https://blog.alexellis.io/docker-is-deleting-open-source-images/). After the large shit-storm they canceled this but the community now knows where their interests are.

Besides that, using GH packages is way easier ;-)

arthurdent75 commented 1 year ago

Please consider to use GH packages rather than docker hub. Docker hub recently did some real bad decisions that made many OSS projects turn away from them (https://blog.alexellis.io/docker-is-deleting-open-source-images/). After the large shit-storm they canceled this but the community now knows where their interests are.

Besides that, using GH packages is way easier ;-)

Thank you for your suggestions. I'll dig into it!

arthurdent75 commented 1 week ago

@micw better late than never...

https://github.com/arthurdent75?tab=packages&repo_name=SimpleScheduler