potential bug in datasets.utils (won't change behavior)

arthurdouillard / CVPR2021_PLOP

Official code of CVPR 2021's PLOP: Learning without Forgetting for Continual Semantic Segmentation

https://arxiv.org/abs/2011.11390

MIT License

140 stars 23 forks source link

potential bug in datasets.utils (won't change behavior) #31

Closed zhaoedf closed 2 years ago

zhaoedf commented 2 years ago

Describe the bug potential bug (won't change behavior)

should it be the "c" variable in the two red rectangles? though "cls" variable won't cause any bugs since the lambda can capture local variables, but this could be confused to some other people.

arthurdouillard commented 2 years ago

Yes, you're right, that's something I also found in the original codebase but got to lazy to fix ahah

I'll try to find time today, to fix that

zhaoedf commented 2 years ago

Yes, you're right, that's something I also found in the original codebase but got to lazy to fix ahah

I'll try to find time today, to fix that

quick reply! thanks