search

arthurdouillard / incremental_learning.pytorch

A collection of incremental learning paper implementations including PODNet (ECCV20) and Ghost (CVPR-W21).
MIT License
383 stars 60 forks source link

The __getitem__ does not adapt to E2E #11

Closed Harry-Up closed 5 years ago

Harry-Up commented 5 years ago

Hello,

Thanks for your continual updates. However, in this version, the getitem of the data loader seems not to adapt to E2E, in which 'real_idxes' and 'idxes' are needed. This information is not provided in this version, while it is ok in old version.

arthurdouillard commented 5 years ago

Hello,

My remote code is not up-to-date compard to by local code.

Please see how I did with iCaRL. The new loader doesn't return the indexes as they are not needed anymore. Instead of saving the previous model outputs and matching them with the new model outputs using the indexes, I choose to re-do a forward pass with the old model given the current inputs.

Hope that helps.