Closed GengDavid closed 2 years ago
Hum, your third class order has weirdly low results while the first two seems to correspond to my paper results.
I'm going to run it on my side.
Ok that's very weird. If I run all three orders one after the other, as you did, I got your results.
But If I launching only the third order (just edit the cifar100_3orders.yaml
file to have only the third order and third seed), I've got avg: 45.77, last: 32.8, forgetting: 41.85
so a "normal" result.
I don't really know the solution, but for now, try running the each class order in a different process maybe. I hope that helps!
Thanks for your feedback! I'll run it separately. If I find the reason, I will back to let you know.
Hi, @arthurdouillard I have another question about your iCaRL implementation. In function build_examplars, it seems that you use all data to reconstruct the exemplar set. For continual learning, I think it is supposed that previous data are not available right? I feel a little confused about this function.
I'm extracting all features because it's simpler that way, but I'm not actually doing any new herding on old data, the line https://github.com/arthurdouillard/incremental_learning.pytorch/blob/0d25c2e12bde4a4a25f81d5e316751c90e6f789b/inclearn/models/icarl.py#L412 means that only new data will be sampled.
However, old data is still reduced https://github.com/arthurdouillard/incremental_learning.pytorch/blob/0d25c2e12bde4a4a25f81d5e316751c90e6f789b/inclearn/models/icarl.py#L451
And note that we only use the selected features and not all features to compute the examplar mean: https://github.com/arthurdouillard/incremental_learning.pytorch/blob/0d25c2e12bde4a4a25f81d5e316751c90e6f789b/inclearn/models/icarl.py#L482
Is that clearer?
I think I missed the if
judgment. Now I see the difference.
Thanks for your kind explanation!
My pleasure :)
Hi, @arthurdouillard Thanks for your great work! I am trying to use your codes to reproduce the icarl method but the results are not as normal as the results in your paper. I run the following script:
I obtain 44.96, 42.55, 27.76 with three seeds, so that avg= 38.43 +/- 9.32. Am I missing something to reproduce the results? Thanks.
Post the log here for reference.