search

arthuredelstein / tor-browser-build

0 stars 1 forks source link

Reverting langpack patch (commit ed39a357) #2

Open azadi opened 6 years ago

azadi commented 6 years ago

I tried reverting commit ed39a357 to get the language packs building again without doing the manual configuration. For reference the changes were:

-  ff_version: '[% pc("firefox", "var/firefox_version") %]'
+  ff_version: 60.0b10

and

-  firefox_version: '[% c("var/firefox_platform_version") %]esr'
+  firefox_version: '[% c("var/firefox_platform_version") %]'

Reverting this results in two errors:

  1. In the var ff_build in firefox-langpacks/config, it should be build6 and not build1. That's easy to fix.
  2. Doing this results in the error:
Starting build: Mon May 21 15:52:10 2018
dl-langpack-linux-i686-60.0b10-build1/ar.xpi: OK
dl-langpack-linux-i686-60.0b10-build1/de.xpi: OK
dl-langpack-linux-i686-60.0b10-build1/es-ES.xpi: OK
dl-langpack-linux-i686-60.0b10-build1/fa.xpi: OK
dl-langpack-linux-i686-60.0b10-build1/fr.xpi: OK
dl-langpack-linux-i686-60.0b10-build1/it.xpi: OK
dl-langpack-linux-i686-60.0b10-build1/ja.xpi: OK
dl-langpack-linux-i686-60.0b10-build1/ko.xpi: OK
dl-langpack-linux-i686-60.0b10-build1/nl.xpi: OK
dl-langpack-linux-i686-60.0b10-build1/pl.xpi: OK
dl-langpack-linux-i686-60.0b10-build1/pt-BR.xpi: OK
dl-langpack-linux-i686-60.0b10-build1/ru.xpi: OK
dl-langpack-linux-i686-60.0b10-build1/tr.xpi: OK
dl-langpack-linux-i686-60.0b10-build1/vi.xpi: OK
dl-langpack-linux-i686-60.0b10-build1/zh-CN.xpi: OK
Starting build: Mon May 21 19:15:14 2018
sha512sum: 'standard input': no properly formatted SHA512 checksum lines found
Starting build: Mon May 21 19:22:41 2018
sha512sum: 'standard input': no properly formatted SHA512 checksum lines found
Starting build: Mon May 21 19:26:52 2018
sha512sum: 'standard input': no properly formatted SHA512 checksum lines found
Starting build: Mon May 21 19:36:17 2018
sha512sum: 'standard input': no properly formatted SHA512 checksum lines found
Starting build: Mon May 21 19:45:44 2018
sha512sum: 'standard input': no properly formatted SHA512 checksum lines found

That's because the corresponding sha512sum files (example) do not have the checksums for the XPI so the command grep 'linux-i686/xpi/fr.xpi$' SHA512SUMS-60.0esr-build6 returns nothing and we get the sha512sum: 'standard input': no properly formatted SHA512 checksum lines found error above.

What's a good potential fix? If you notice the config file without reverting the commit, it points to this file, which has the relevant checksums for the XPI files and hence the build completes successfully.

azadi commented 6 years ago

For tracking, upstream bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1463749