search

arthurelmes / sat-city

Other
0 stars 1 forks source link

New CLI args #13

Open arthurelmes opened 1 year ago

arthurelmes commented 1 year ago

Nice, I like this direction! What are some other future arguments? I'm thinking of going in a direction that does time series analysis. I am thinking of adding a "before" and "after" time range argument to get a comparative analyses going.

Originally posted by @BilyBrown in https://github.com/arthurelmes/sat-city/pull/12#pullrequestreview-1539568737

arthurelmes commented 1 year ago

Cool, yeah I would say we should add args for at least the start_date, end_date, and bbox, which defines the AOI by its four corners: left, bottom, right, top. Then we can just keep adding args as needed!

BilyBrown commented 1 year ago

I was thinking of adding an option for a geojson to define AOIs. What are your thoughts?

On Thu, Jul 20, 2023, 12:03 Arthur Elmes @.***> wrote:

Cool, yeah I would say we should add args for at least the start_date, end_date, and bbox, which defines the AOI by its four corners: left, bottom, right, top. Then we can just keep adding args as needed!

— Reply to this email directly, view it on GitHub https://github.com/arthurelmes/sat-city/issues/13#issuecomment-1644194655, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXLT7ITP6VH2Y6ZIBLN7Q23XRFJFPANCNFSM6AAAAAA2RUVOKA . You are receiving this because you were mentioned.Message ID: @.***>

arthurelmes commented 1 year ago

@BilyBrown My thoughts are positive :p

Yeah, it should totally be able to accept a geojson (and maybe even WKT polygon, but probably in separate PRs).