search

arthurfiorette / axios-cache-interceptor

📬 Small and efficient cache interceptor for axios. Etag, Cache-Control, TTL, HTTP headers and more!
https://axios-cache-interceptor.js.org
MIT License
703 stars 58 forks source link

fix: aborted requests should not clear its cache afterwards if previous request was cached (#922) #923

Closed Wykks closed 1 month ago

Wykks commented 1 month ago

I'm not super convinced with the quality of the fix, but since it's a special case, maybe it's okay like that.

Ref: https://github.com/arthurfiorette/axios-cache-interceptor/issues/922

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.60%. Comparing base (a7a4e31) to head (de11ef5). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #923 +/- ## ======================================= Coverage 99.59% 99.60% ======================================= Files 19 19 Lines 2498 2509 +11 Branches 219 223 +4 ======================================= + Hits 2488 2499 +11 Misses 10 10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

arthurfiorette commented 1 month ago

overall, good work!

arthurfiorette commented 1 month ago

thanks for your work!