search

arthurgarzajr / MMM-DailyBibleVerse

MIT License
27 stars 15 forks source link

Localization of Bible reference for de, en, es, nl #6

Closed pinsdorf closed 5 years ago

pinsdorf commented 6 years ago

The version setting in this module defines the Bible and hence also the language of the verse of the day. However, the Bible reference is always in English, e.g. "1 Corinthians 13:6,7", because that is how the API of biblegateway.com works.

This PR localizes the reference based on the global language parameter in user's config.js file. Translation uses MM's standard translation mechanism. The PR contains already localizations for German, Dutch, and Spanish. More languages are easy to add.

pinsdorf commented 6 years ago

Friendly reminder that this pull request is still open. Thanks.

pinsdorf commented 5 years ago

Friendly reminder to integrate localization of bible references from this pull request into your codebase. Thanks!

arthurgarzajr commented 5 years ago

Thank you also for making this localized! This is great.